Code review · SecurityA live Helius RPC credential is committed in source, replacing the documented SOLANA_RPC_URL env var, leaking a secret into the repository and making the CLI ignore its documented configuration.solana/scripts/cli.ts:66-66
Code review · Code qualityThe entire TypeScript file is reformatted from 2-space to 4-space indentation with no functional reason, producing large unrelated churn that buries the one real change in this PR.solana/scripts/cli.ts:27-200
Code review · CorrectnessHardcoding the endpoint drops the SOLANA_RPC_URL override (and the devnet default fallback), a behavioral regression unrelated to the stated issue #27 fix.solana/scripts/cli.ts:66-66
Code review · TestsOnly one happy-path test is added; the new maxErrorLines / maxErrorChars truncation branches and the companion solana.go message-flattening change are untested.cre-runner/simulate_test.go:170-189
Code review · CorrectnessThe continuation collector stops at any line starting with '!' or containing box-drawing chars within the first three bytes, which can silently truncate legitimate error text that happens to begin with those characters.cre-runner/simulate.go:178-207
Issue fit · ValueHardcodes a live Helius RPC endpoint with an embedded API key, leaking a credential into the public repo.solana/scripts/cli.ts:63-64
Issue fit · ScopeReplaces the configurable SOLANA_RPC_URL env lookup with the hardcoded URL, silently breaking user RPC overrides and localnet use.solana/scripts/cli.ts:64
Issue fit · ScopeRewrites essentially the whole file with a 2-to-4 space reindent, producing large churn unrelated to the stated error-message fix.solana/scripts/cli.ts:25-190
Issue fit · ScopeThis TypeScript CLI change is unrelated to the Solana payout/error-reporting concern described in the linked issue, splitting the PR across two independent concerns.solana/scripts/cli.ts:1-190
Issue fit · ValueNew helper relies on regexp and the min builtin; if imports were not added the package will not compile, and the change is untested beyond a single case.cre-runner/simulate.go:181-208